[asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/
-----------------------------------------------------------

(Updated 2011-05-09 05:25:07.386356)


Review request for Asterisk Developers, Russell Bryant, Matthew Nicholson, dimas, Leif Madsen, and dafe_von_cetin.


Changes
-------

#19251 Fix Framehook API

A framehook has 2 events relating to frames read/write

a frame hook on a bridged channel can look at the write events to see the packets coming into [read] on the peer.

the problem with control frames is they are not sent across the bridge using a ast_write but a ast_indicate_data so to see these packets framehook events are triggered in ast_indicate_data ... these are WRITE not READ events and causes most peculiar results ...

in addition there is no certainty a AST_FRAME_CONTROL will be sent back perhaps a AST_FRAME_NULL or someother frame .... i add a sanity check ...

The patch is included here [main/channel.c]

this solves my problem of bridge eating control frames and causing chaos ...

Greg


Summary
-------

Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
unfortunately i have no means of testing it at the moment and require help.

i have cleaned the code up substantially it is related to R459

hope this is found useful and aids in the goal to get it in 1.10.

Adds application FaxGateway / FaxDetect
Adds alternate bridge to Dial with new option.


This addresses bugs 13405, 19215 and 19251.
    https://issues.asterisk.org/view.php?id=13405
    https://issues.asterisk.org/view.php?id=19215
    https://issues.asterisk.org/view.php?id=19251


Diffs
-----

  /trunk/apps/app_faxdetect.c PRE-CREATION 
  /trunk/channels/chan_sip.c 318105 
  /trunk/channels/sip/include/sip.h 318105 
  /trunk/include/asterisk/res_fax.h 318105 
  /trunk/main/channel.c 318105 
  /trunk/res/res_fax.c 318105 
  /trunk/res/res_fax_spandsp.c 318105 

Diff: https://reviewboard.asterisk.org/r/1116/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110509/08b99f77/attachment.htm>