[asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/
-----------------------------------------------------------

(Updated 2011-05-08 16:28:26.501533)


Review request for Asterisk Developers, Russell Bryant, Matthew Nicholson, dimas, Leif Madsen, and dafe_von_cetin.


Changes
-------

Ok this is a major milestone ..

all the architectural conditions should now have been met.

1)the T38 Gateway runs in a single framehook
2)it is not in any core loops/bridges or structures other than the above
3)its CED detection is functional but still does not trigger T.38 neg.

this has been done by fixing what i consider a bug in the framehook API.

Could someone look at the "sip" bits and possibly push them through.

what is the status of this re 1.8 in the release the door was left open
for a T.38 gateway im maintaing both a 1.8 and trunk version once trunk is done
the 1.8 will be posted to mantis.

Thx 

Greg


Summary
-------

Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
unfortunately i have no means of testing it at the moment and require help.

i have cleaned the code up substantially it is related to R459

hope this is found useful and aids in the goal to get it in 1.10.

Adds application FaxGateway / FaxDetect
Adds alternate bridge to Dial with new option.


This addresses bugs 13405 and 19215.
    https://issues.asterisk.org/view.php?id=13405
    https://issues.asterisk.org/view.php?id=19215


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 318105 
  /trunk/channels/sip/include/sip.h 318105 
  /trunk/apps/app_faxdetect.c PRE-CREATION 
  /trunk/include/asterisk/res_fax.h 318105 
  /trunk/main/channel.c 318105 
  /trunk/res/res_fax.c 318105 
  /trunk/res/res_fax_spandsp.c 318105 

Diff: https://reviewboard.asterisk.org/r/1116/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110508/2ffcb4e7/attachment.htm>