[asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/
-----------------------------------------------------------

(Updated 2011-05-04 17:09:07.326588)


Review request for Asterisk Developers, Russell Bryant, Matthew Nicholson, dimas, Leif Madsen, and dafe_von_cetin.


Changes
-------

Ok i have made the changes i could based on the feedback i require a bit of help / ideas on how to move forward with some sticky problems.

this version the framehook has its own datastore and messy variables removed s->peer / details->owner / details->framehook

there is now some DSP logic to detect fax tones the idea is to trigger T.38 negotiation.

i need to keep the hook into the bridge or i need to run a second frame hook for T.38 neg

the DSP FAX detect needs to know what conditions to act on and how do i act what to i queue/indicate to get T.38 moving ... do i only do it on CED when one channel is T.38 incapable ... ??

Please assist ...


Summary
-------

Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
unfortunately i have no means of testing it at the moment and require help.

i have cleaned the code up substantially it is related to R459

hope this is found useful and aids in the goal to get it in 1.10.

Adds application FaxGateway / FaxDetect
Adds alternate bridge to Dial with new option.


This addresses bugs 13405 and 19215.
    https://issues.asterisk.org/view.php?id=13405
    https://issues.asterisk.org/view.php?id=19215


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 316884 
  /trunk/channels/sip/include/sip.h 316884 
  /trunk/apps/app_faxdetect.c PRE-CREATION 
  /trunk/include/asterisk/channel.h 316884 
  /trunk/include/asterisk/res_fax.h 316884 
  /trunk/main/channel.c 316884 
  /trunk/res/res_fax.c 316884 
  /trunk/res/res_fax_spandsp.c 316884 

Diff: https://reviewboard.asterisk.org/r/1116/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110504/58ec3a1a/attachment.htm>