[asterisk-dev] [Code Review] Add getnameinfo() to ast_sockaddr_resolve()

[Paul Belanger]

> On 2011-05-03 13:53:54, Simon Perreault wrote:
> > This patch looks very wrong to me.
> > 
> > What are you trying to accomplish?

The problem is documented in the issue, but basically if you dial an no exist SIP peer, Asterisk will continue to dial and transmit INVITES to a bogus IP.

https://issues.asterisk.org/file_download.php?file_id=28015&type=bug


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1202/#review3460
-----------------------------------------------------------


On 2011-05-03 13:36:52, Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1202/
> -----------------------------------------------------------
> 
> (Updated 2011-05-03 13:36:52)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I spend some time last week trying to resolve an issue when you Dial() an unknown SIP peer. EG: Dial(SIP/blah).  When we moved to IPv6 support we changed the way lookups were done.  I took some time to research on the Internet, and found a few examples of how to use getnameinfo() as an additional error check for getaddrinfo().
> 
> 
> This addresses bug 18514.
>     https://issues.asterisk.org/view.php?id=18514
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 314598 
>   trunk/main/netsock2.c 314598 
> 
> Diff: https://reviewboard.asterisk.org/r/1202/diff
> 
> 
> Testing
> -------
> 
> Local testing and user on issue tracker.
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110503/63f36274/attachment.htm>