[asterisk-dev] [Code Review] extra ast_strlen_zero() check in cel_odbc prevents integer eventtype in database

[mlehner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1149/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

event_type could not be an integer datatype in a ODBC database because an extra ast_strlen_zero() check was wrapped around the code that did the work. ast_strlen_zero() check is done in the second branch of the if statement, after the check for eventtype is done. Changes are very simple, just removing the "overzealous" ast_strlen_zero() check, while keeping braces to prevent compilation errors and warnings with variable re-definitions. 


Diffs
-----

  /tags/1.8.3.2/cel/cel_odbc.c 311686 

Diff: https://reviewboard.asterisk.org/r/1149/diff


Testing
-------

Tested on a local install of Asterisk 1.8.3.2. Compiles and creates the expected records in the database.


Thanks,

mlehner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110326/9b680ee9/attachment.htm>