[asterisk-dev] [Code Review] Pseudo-channel and more user information in MeetmeJoin and MeetmeList AMI events

[clegall_proformatique]

> On 2011-03-23 08:19:35, Olle E Johansson wrote:
> > /trunk/apps/app_meetme.c, line 2761
> > <https://reviewboard.asterisk.org/r/1146/diff/1/?file=15943#file15943line2761>
> >
> >     I do not like values with space in them.

You're right. I agree with you completely, however it is almost only a copy-paste of some existing code ...


- clegall_proformatique


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1146/#review3250
-----------------------------------------------------------


On 2011-03-23 08:16:42, clegall_proformatique wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1146/
> -----------------------------------------------------------
> 
> (Updated 2011-03-23 08:16:42)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The MeetmeList event already provides some useful informations as to the various channels involved in a conference room.
> This patch provides the same level of information inside the MeetmeJoin event.
> Besides, a field PseudoChan has been added to both events in order to be able to match against the proper DAHDI/pseudo-xxxx channel that is created with the conference.
> 
> The patch is provided against the current trunk, but it would be welcome to be included into the 1.8 branch as well, the diff is the same.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_meetme.c 311603 
> 
> Diff: https://reviewboard.asterisk.org/r/1146/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> clegall_proformatique
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110323/eabc8390/attachment-0001.htm>