[asterisk-dev] SipAddHeader and SIP REFER

[Kirill Katsnelson]

On 110315 0845, Olle E. Johansson wrote:
>
> 15 mar 2011 kl. 16.35 skrev Russell Bryant:
>
>> On Tue, 2011-03-15 at 09:01 +0100, Olle E. Johansson wrote:
>>> 1) Be careful with locking issues. I added something that checked channel variables during a call (MAX_FORWARDS) that we simply could not solve.
>>> If you want to use this for a REFER during a call, you're in the same neighbourhood. That's no good.
>>
>> You're right that this is something to watch out for.  We can make sure
>> it's safe through peer code review though.
>
> Since we found no solution to this, but reverted backwards and avoided the problem - do you have any advice on how
> to solve this so we don't put this developer on a bad track from start. That's not very nice :-)

Are we talking about a similar code path here? Is not sip_transfer() in 
chan_sip called with the channel already locked, just like sip_call() is?

  -kkm