[asterisk-dev] [Code Review] Set T38 State To UNAVAILABLE when we could not negotiate T38

irroot reviewboard at asterisk.org
Sun Feb 27 12:03:19 CST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1115/
-----------------------------------------------------------

(Updated 2011-02-27 12:03:19.636883)


Review request for Asterisk Developers.


Changes
-------

Two small changes now reports T38_STATE_REJECTED and the code hunk 3 previously was never executed
state changed before it was run.


Summary
-------

When a error in T.38 negotiation happens or its rejected on a channel the
state of the channel reverts to unknown this should be unavailable.

this is important for negotiating T.38 gateway see 0013405

This patch adds a option T38_REJECTED that behaves as T38_DISABLED except it reports state unavailable when asked. 


This addresses bug 18889.
    https://issues.asterisk.org/view.php?id=18889


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 308944 
  /trunk/channels/sip/include/sip.h 308944 

Diff: https://reviewboard.asterisk.org/r/1115/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110227/69ceff9e/attachment.htm>


More information about the asterisk-dev mailing list