[asterisk-dev] [Code Review] RFC 3261 compliant ACK retransmission for unreliable final responses

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/692/#review3209
-----------------------------------------------------------


Upon reading http://tools.ietf.org/html/rfc3261#section-16.11 I believe the Via branch should be the *same* as the original. With this patch, a new Via-branch is generated for the new ACK.

- wdoekes


On 2010-06-03 13:40:43, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/692/
> -----------------------------------------------------------
> 
> (Updated 2010-06-03 13:40:43)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> RFC 3261 in sections 13.2.24 and 17.1.1.2 state that each 2xx response or final response to an INVITE must result in an ACK being sent (but the retransmitted responses are not to be sent to the transaction user).
> 
> This patch sends that ACK.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 267137 
> 
> Diff: https://reviewboard.asterisk.org/r/692/diff
> 
> 
> Testing
> -------
> 
> I wrote a sipp scenario to re-send 200 OK responses and ensured that the proper ACK was sent back. I also tested calling a soft phone to verify that no behavior change was made when there were no retransmissions.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110221/2c9035a7/attachment.htm>