[asterisk-dev] [Code Review] app_queue per member ringinuse [ignorebusy] / set chan group on answer / change behaviour of neg penalty

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1119/
-----------------------------------------------------------

(Updated 2011-02-20 11:28:22.067238)


Review request for Asterisk Developers.


Changes
-------

the changroup bits are pointless as they can be done in the dialplan.

modified QUEUE_MEMBER to be read write allowing changing/reading member options, this will allow deprecating
QUEUE_MEMBER_PENALTY.

Modified set penalty to work with realtime and non realtime peers.


Summary
-------

This patch is a combination of 3 changes id like to submit.

1)allow a per member ringinuse setting called ignorebusy this was a requirement of a customer and and has been most useful
2)when a call is answered set a channel group this can be used to count active calls as well as be used to not send calls to users flaged above in the dialplan
3)when a member penalty is negative see this as a logged off agent this is a behavior change that allows "removing" realtime agents as well as making IMHO more logic sense if the penalty is neg its not valid 

NB: this is a global config option now as not to change behavior.

4)allow a "grace" period for autopause queue option "autopausedelay" [as requested by a customer we support]

Enjoy the fish


This addresses bugs 18794, 18825 and 18826.
    https://issues.asterisk.org/view.php?id=18794
    https://issues.asterisk.org/view.php?id=18825
    https://issues.asterisk.org/view.php?id=18826


Diffs (updated)
-----

  /trunk/configs/queues.conf.sample 308283 
  /trunk/apps/app_queue.c 308283 

Diff: https://reviewboard.asterisk.org/r/1119/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110220/75e2c0db/attachment.htm>