[asterisk-dev] Query of an app_dial diff from SVN

[Steve Davies]

On 17 February 2011 16:31, Mark Michelson <mmichelson at digium.com> wrote:
> On 02/17/2011 05:09 AM, Steve Davies wrote:
>>
>> Is this patch really correct???
>>
>> It is taken from branch/1.6.2/apps/app_dial.c
>>
>>
>> @@ -1614,7 +1614,7 @@
>>                         pbx_builtin_setvar_helper(chan, "DIALSTATUS",
>> pa.status);
>>                         goto done;
>>                 }
>> -               ast_verb(3, "Setting call duration limit to %.3lf
>> seconds.\n", calldurationlimit.tv_sec + calldurationlimit.tv_usec /
>> 1000000.0);
>> +               ast_verb(3, "Setting call duration limit to %.3lf
>> milliseconds.\n", calldurationlimit.tv_sec + calldurationlimit.tv_usec
>> / 1000000.0);
>>         }
>>
>>         if (ast_test_flag64(&opts, OPT_SENDDTMF)&&
>> !ast_strlen_zero(opt_args[OPT_ARG_SENDDTMF])) {
>>
>>
>> The original version looks more correct to me.
>>
>> Regards,
>> Steve
>
> This was reverted in revision 303273.

I think that there may be 2 cases of this, and only one has been
rolled-back. Run just now:

$ svn update branches/1.6.2/ tags/1.6.2.17-rc2/
[snip]
At revision 308283.

$ grep "Setting call duration"  branches/1.6.2/apps/app_dial.c
                ast_verb(3, "Setting call duration limit to %.3lf seconds.\n",
                ast_verb(3, "Setting call duration limit to %.3lf
milliseconds.\n", calldurationlimit.tv_sec + calldurationlimit.tv_usec
/ 1000000.0);

Regards,
Steve