[asterisk-dev] [Code Review] new testcase to test loading / unloading for modules.

Paul Belanger reviewboard at asterisk.org
Tue Feb 15 14:18:47 CST 2011



> On 2011-01-21 10:20:13, Russell Bryant wrote:
> > asterisk/trunk/tests/dynamic-modules/run-test, lines 95-96
> > <https://reviewboard.asterisk.org/r/653/diff/3/?file=14821#file14821line95>
> >
> >     Here's another way you can build res in one line:
> >     
> >     res = [ (module + ".so", False, False, False) for module in resources ]

done


> On 2011-01-21 10:20:13, Russell Bryant wrote:
> > asterisk/trunk/tests/dynamic-modules/run-test, lines 101-110
> > <https://reviewboard.asterisk.org/r/653/diff/3/?file=14821#file14821line101>
> >
> >     Sleeps usually set off a red flag for me.  Is there a way this could be done without hard coded sleeps?

removed. I added them not to flood asterisk with loading / unloading modules.  Lets see what happens :)


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/653/#review3117
-----------------------------------------------------------


On 2011-01-04 21:06:29, Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/653/
> -----------------------------------------------------------
> 
> (Updated 2011-01-04 21:06:29)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is my first test-case used to test the loading / unloading of modules.  Currently it only check res modules, once the core design is complete additional modules will be added.
> 
> I've create 2 new feature in the asterisk library, getBase (needed to check if modules actually exists / compiled) and CLI output (needed to confirm module was loaded / unloaded).
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/dynamic-modules/configs/ast1/modules.conf PRE-CREATION 
>   asterisk/trunk/tests/dynamic-modules/run-test PRE-CREATION 
>   asterisk/trunk/tests/dynamic-modules/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/tests.yaml 1333 
> 
> Diff: https://reviewboard.asterisk.org/r/653/diff
> 
> 
> Testing
> -------
> 
> Local development / QA box. Not all modules tested yet, as I was missing the dependencies.
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110215/2884684d/attachment-0001.htm>


More information about the asterisk-dev mailing list