[asterisk-dev] [Code Review] Use 'remotesecret' when it is set instead of 'secret' when authenticating to a remote party

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1107/
-----------------------------------------------------------

Review request for Asterisk Developers, Olle E Johansson and David Vossel.


Summary
-------

Asterisk 1.6.2+ has the 'remotesecret' config option which is documented to be the password we use when connecting out to a peer. The 'secret' option is supposed to be used for when we are authenticating an inbound request. 'remotesecret' currently works for registration, but for sending an INVITE the 'secret' is used instead. This patch tests if we are making an outgoing request and uses the peer remotesecret if it is set. Otherwise it still uses the secret as it always has.


Diffs
-----

  /branches/1.6.2/channels/chan_sip.c 307791 

Diff: https://reviewboard.asterisk.org/r/1107/diff


Testing
-------

Tested that a peer with a 'remotesecret' used that on an outbound call. Tested that if remotesecret is not set, secret is used.


Thanks,

Terry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110214/85bd3229/attachment-0001.htm>