[asterisk-dev] [Code Review] 0018729: [regression] Dial() and Queue() with a macro argument are broken by AEL macro compilation change

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1097/#review3171
-----------------------------------------------------------


Unfortunately, this will break every dialplan which is NOT using AEL.  In other words, the vast majority of dialplans.  If there were a checkbox for "abandon this patch and start over", I would mark it.

- Tilghman


On 2011-02-08 20:22:32, kkm wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1097/
> -----------------------------------------------------------
> 
> (Updated 2011-02-08 20:22:32)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> #18480 replaced AEL "macro" entry point from "s" to "~~s~~". Dial() and Queue() still sent their GoSub invocation into the extension "s", and failed. Here I changed the target extension in Dial and Queue to match the "~~s~~".
> 
> I am pretty sure these are the only places where the extension is mentioned, but please confirm.
> 
> 
> This addresses bug 18729.
>     https://issues.asterisk.org/view.php?id=18729
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_dial.c 307141 
>   /trunk/apps/app_queue.c 307141 
> 
> Diff: https://reviewboard.asterisk.org/r/1097/diff
> 
> 
> Testing
> -------
> 
> 1.8.3 rc2 with this patch successfully dispatches calls on our live server now (shudders).
> 
> 
> Thanks,
> 
> kkm
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110209/f8ef6b0f/attachment.htm>