[asterisk-dev] [Code Review] "r" dial params stop give ringback if M macro used

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1398/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

When a single channel is dialed and there is media to be forwarded to the calling channel, the media is written without regard for ringback causing silence to be heard in some circumstances.  This regression was introduced when the meaning of "single" changed to mean only the number of channels dialed.


This addresses bug ASTERISK-18083.
    https://issues.asterisk.org/jira/browse/ASTERISK-18083


Diffs
-----

  trunk/apps/app_dial.c 333475 

Diff: https://reviewboard.asterisk.org/r/1398/diff


Testing
-------

Verified that the behavior of multiple dialed channels with these options remained unchanged while the behavior of a single dialed channel that attempted to send media was corrected when ringback was requested.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110829/6e1f8c03/attachment.htm>