[asterisk-dev] [Code Review] Some cleanups for the recently commited T38 Gw timeout option

[Matthew Nicholson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1385/#review4169
-----------------------------------------------------------



/branches/10/CHANGES
<https://reviewboard.asterisk.org/r/1385/#comment8210>

    Why was this changed?



/branches/10/res/res_fax.c
<https://reviewboard.asterisk.org/r/1385/#comment8211>

    (yes[,timeout]/no)



/branches/10/res/res_fax.c
<https://reviewboard.asterisk.org/r/1385/#comment8213>

    Should default to 0.



/branches/10/res/res_fax.c
<https://reviewboard.asterisk.org/r/1385/#comment8212>

    details->gateway_timeout needs to be set to 0 here



/branches/10/res/res_fax.c
<https://reviewboard.asterisk.org/r/1385/#comment8214>

    We don't need to check for strlen_zero


- Matthew


On Aug. 29, 2011, 11:20 a.m., irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1385/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2011, 11:20 a.m.)
> 
> 
> Review request for Asterisk Developers and Matthew Nicholson.
> 
> 
> Summary
> -------
> 
> Recent Changes to res_fax.c to support configurable timeout is not optimal here is a fixup.
> 
> 
> This addresses bug ASTERISK-18219.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18219
> 
> 
> Diffs
> -----
> 
>   /branches/10/CHANGES 333337 
>   /branches/10/res/res_fax.c 333337 
> 
> Diff: https://reviewboard.asterisk.org/r/1385/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110829/f61690ab/attachment.htm>