[asterisk-dev] [Code Review] TestSuite logging addition

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1382/#review4167
-----------------------------------------------------------

Ship it!


Logger.conf is missing, but the logs folder, be sure to add them when you merged. You might want to confirm your voicemail.py changes don't break the existing tests (checkGreetingExists), I had trouble with them on Friday.  Might be better just to leave them out of this merged and add them back into your previous voicemail tests.

Good work.

- Paul


On Aug. 29, 2011, 10:04 a.m., mjordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1382/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2011, 10:04 a.m.)
> 
> 
> Review request for Asterisk Developers and Paul Belanger.
> 
> 
> Summary
> -------
> 
> Pulled out the logging functionality from review 1380 (https://reviewboard.asterisk.org/r/1380/).  That review will be updated once this review is completed.
> 
> This review adds Python logging to the test suite.  The Python libraries were updated to use this.  Note that runtests.py now creates a log file log-console-output.txt to not conflict with the Python log created by TestCase.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/asttest/asttest.c 1997 
>   /asterisk/trunk/lib/python/asterisk/TestCase.py 1997 
>   /asterisk/trunk/lib/python/asterisk/ami.py 1997 
>   /asterisk/trunk/lib/python/asterisk/asterisk.py 1997 
>   /asterisk/trunk/lib/python/asterisk/cdr.py 1997 
>   /asterisk/trunk/lib/python/asterisk/config.py 1997 
>   /asterisk/trunk/lib/python/asterisk/sipp.py 1997 
>   /asterisk/trunk/lib/python/asterisk/version.py 1997 
>   /asterisk/trunk/lib/python/asterisk/voicemail.py 1997 
>   /asterisk/trunk/lib/python/client.py 1997 
>   /asterisk/trunk/runtests.py 1997 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast2/extensions.conf 1997 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/run-test 1997 
>   /asterisk/trunk/tests/apps/voicemail/tests.yaml 1997 
> 
> Diff: https://reviewboard.asterisk.org/r/1382/diff
> 
> 
> Testing
> -------
> 
> Python logging was used in all of the new VoiceMailMain tests, on review at https://reviewboard.asterisk.org/r/1380/.  Tested with a variety of log levels, including DEBUG, INFO, WARN, and ERROR.
> 
> 
> Thanks,
> 
> mjordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110829/53a9abde/attachment.htm>