[asterisk-dev] [Code Review] Pickup problems with channels with no pvt_tech orphaned channels part 2

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1397/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

A sip phone tries to pickup a call but for some reason looses the pvt this causes all sorts of mischief.

Im proposing that sip_hangup return -1 when there is no private it has failed what it should be doing.
if the hangup fails ast_do_masquerade will kill the channel and return not leaving the channel orphaned.

[Aug 26 10:50:21] NOTICE[29961] app_directed_pickup.c: pickup SIP/2201-0000167c attempt by SIP/2225-0000168c
[Aug 26 10:50:22] WARNING[29961] chan_sip.c: No SIP tech_pvt! Fixup of SIP/2225-0000168c failed.
[Aug 26 10:50:22] WARNING[29961] channel.c: Fixup failed on channel SIP/2225-0000168c<MASQ>, strange things may happen.
[Aug 26 10:51:23] NOTICE[21093] chan_sip.c: Disconnecting call 'SIP/2225-0000168c' for lack of RTP activity in 61 seconds


Diffs
-----

  /team/irroot/distrotech-customers-1.8/channels/chan_sip.c 333499 
  /team/irroot/distrotech-customers-1.8/main/channel.c 333499 
  /team/irroot/distrotech-customers-1.8/main/features.c 333499 

Diff: https://reviewboard.asterisk.org/r/1397/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110829/f927a331/attachment.htm>