[asterisk-dev] Tagging commits with issue numbers

[Tilghman Lesher]

On Sunday 28 August 2011 05:32:01 Tzafrir Cohen wrote:
> On Tue, Aug 16, 2011 at 11:31:58AM -0400, Russell Bryant wrote:
> > Related wiki page which may need some updating:
> > 
> > https://wiki.asterisk.org/wiki/display/AST/Commit+Messages
> 
> I'm not sure I'm happy with it:
> 
> "Signed-off-by" is just a header git easily adds (git commit -s). It
> normally implies the identity of the author of the patch (regardless of
> who actually commited it). Which makes it the exact equivalent of that
> author from that complex-to-parse "Patches" field.

Irrelevant.  We're not using Git (yet).  If you're finding fundamental
incompatibilities between your own adaptation and our version control
system, that is an issue that you need to work out locally, not place upon
the project to solve.

> Also, if the bug tracker will display the list of patches effectivly,
> why bother with including part of that information in patches (only one
> direction)? Recall that the URL included there is invalid anyway.

Because there may be more than one patch on the issue, solving the
problem in different ways.  The commit message disambiguates as to
which patch was actually applied.

-- 
Tilghman