[asterisk-dev] [Code Review]: Fix app_sms regression

[dwmw2]

> On Aug. 26, 2011, 8:38 p.m., Paul Belanger wrote:
> > Wow, something wrong with this diff.  Not sure what happened, but lots of unneeded changes included.

Oops, sorry. Still learning to use post-review, and I think it picked the wrong branch of my git-svn tree to use as a base. Should be fixed now.


- dwmw2


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1392/#review4151
-----------------------------------------------------------


On Aug. 26, 2011, 6:36 p.m., dwmw2 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1392/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2011, 6:36 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Fix two problems with app_sms.
> 
> Firstly, the 'flags' field on the stack in sms_exec() is uninitialised, causing it to use the wrong protocol in some cases.
> 
> Secondly, when disconnect supervision is not working or inbanddisconnect=yes is set in chan_dahdi.conf, app_sms was failing to terminate the call after it sent the REL(ease) message and the peer stopped talking to it. This patch fixes the code to handle the 'bad stop bit' message more gracefully in that case, and hang up the call.
> 
> 
> This addresses bug ASTERISK-18331.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18331
> 
> 
> Diffs
> -----
> 
>   /trunk/Makefile 333075 
>   /trunk/apps/app_sms.c 333428 
>   /trunk/apps/app_voicemail.c 333075 
>   /trunk/build_tools/mkpkgconfig 333075 
>   /trunk/channels/chan_local.c 333075 
>   /trunk/configure 333075 
>   /trunk/configure.ac 333075 
>   /trunk/makeopts.in 333075 
>   /trunk/res/res_fax.c 333075 
>   /trunk/res/res_jabber.c 333075 
>   /trunk/sounds/Makefile 333075 
> 
> Diff: https://reviewboard.asterisk.org/r/1392/diff
> 
> 
> Testing
> -------
> 
> Sending and receiving protocol 1 messages to/from British Telecom over ISDN BRI (with chan_dahdi), both with and without inbanddisconnect=yes.
> 
> 
> Thanks,
> 
> dwmw2
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110827/554dd352/attachment-0001.htm>