[asterisk-dev] [Code Review] Remove OptionParser from tests

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1386/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

This patch removes the OptionParser logic from all tests, and fixes the following:

A) It is deprecated in python 2.7
2) Is a sloppy way to pass data into a test
3) Not even needed.

I've also added cli_aliases.conf file to fix the logic around ast_version.


Diffs
-----

  asterisk/trunk/tests/manager/login/run-test 1959 
  asterisk/trunk/tests/manager/event-monitor/run-test 1959 
  asterisk/trunk/tests/iax2/basic-call/run-test 1959 
  asterisk/trunk/tests/func_srv/run-test 1959 
  asterisk/trunk/tests/feature_blonde_transfer/run-test 1959 
  asterisk/trunk/tests/fax/gateway_native_t38_ced/run-test 1959 
  asterisk/trunk/tests/fax/gateway_no_t38/run-test 1959 
  asterisk/trunk/tests/fax/gateway_t38_g711/run-test 1959 
  asterisk/trunk/tests/fax/gateway_timeout1/run-test 1959 
  asterisk/trunk/tests/fax/gateway_timeout2/run-test 1959 
  asterisk/trunk/tests/fax/gateway_timeout3/run-test 1959 
  asterisk/trunk/tests/fax/gateway_timeout4/run-test 1959 
  asterisk/trunk/tests/fax/gateway_timeout5/run-test 1959 
  asterisk/trunk/tests/feature_attended_transfer/run-test 1959 
  asterisk/trunk/tests/fax/gateway_native_t38/run-test 1959 
  asterisk/trunk/tests/fax/gateway_mix4/run-test 1959 
  asterisk/trunk/tests/fax/gateway_mix3/run-test 1959 
  asterisk/trunk/tests/fax/gateway_mix2/run-test 1959 
  asterisk/trunk/tests/fax/gateway_g711_t38/run-test 1959 
  asterisk/trunk/tests/fax/gateway_mix1/run-test 1959 
  asterisk/trunk/tests/fastagi/wait-for-digit/run-test 1959 
  asterisk/trunk/tests/fastagi/stream-file/run-test 1959 
  asterisk/trunk/tests/fastagi/say-time/run-test 1959 
  asterisk/trunk/tests/fastagi/record-file/run-test 1959 
  asterisk/trunk/tests/fastagi/say-alpha/run-test 1959 
  asterisk/trunk/tests/fastagi/say-date/run-test 1959 
  asterisk/trunk/tests/fastagi/say-datetime/run-test 1959 
  asterisk/trunk/tests/fastagi/say-digits/run-test 1959 
  asterisk/trunk/tests/fastagi/say-number/run-test 1959 
  asterisk/trunk/tests/fastagi/say-phonetic/run-test 1959 
  asterisk/trunk/tests/fastagi/hangup/run-test 1959 
  asterisk/trunk/tests/fastagi/get-data/run-test 1959 
  asterisk/trunk/tests/fastagi/execute/run-test 1959 
  asterisk/trunk/tests/fastagi/database/run-test 1959 
  asterisk/trunk/tests/fastagi/control-stream-file/run-test 1959 
  asterisk/trunk/tests/fastagi/connect/run-test 1959 
  asterisk/trunk/tests/dynamic-modules/run-test 1959 
  asterisk/trunk/tests/fastagi/channel-status/run-test 1959 
  asterisk/trunk/tests/channels/SIP/sip_tls_call/run-test 1959 
  asterisk/trunk/tests/chanspy/chanspy_barge/run-test 1959 
  asterisk/trunk/tests/chanspy/chanspy_w_mixmonitor/run-test 1959 
  asterisk/trunk/tests/directed_pickup/run-test 1959 
  asterisk/trunk/tests/channels/SIP/sip_srtp/run-test 1959 
  asterisk/trunk/tests/channels/SIP/sip_register/run-test 1959 
  asterisk/trunk/tests/channels/SIP/sip_one_legged_transfer_v6/run-test 1959 
  asterisk/trunk/tests/channels/SIP/sip_one_legged_transfer/run-test 1959 
  asterisk/trunk/tests/channels/SIP/sip_attended_transfer_v6/run-test 1959 
  asterisk/trunk/tests/channels/SIP/sip_attended_transfer_tcp/run-test 1959 
  asterisk/trunk/tests/channels/SIP/sip_attended_transfer/run-test 1959 
  asterisk/trunk/configs/cli_aliases.conf PRE-CREATION 
  asterisk/trunk/lib/python/asterisk/TestCase.py 1959 
  asterisk/trunk/runtests.py 1959 
  asterisk/trunk/tests/apps/directory_attendant_exit/run-test 1959 
  asterisk/trunk/tests/apps/directory_context_operator_exit/run-test 1959 
  asterisk/trunk/tests/apps/directory_operator_exit/run-test 1959 
  asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/run-test 1959 
  asterisk/trunk/tests/blind-transfer-parkingtimeout/run-test 1959 
  asterisk/trunk/tests/callparking/run-test 1959 
  asterisk/trunk/tests/channels/SIP/message_auth/run-test 1959 
  asterisk/trunk/tests/channels/SIP/message_disabled/run-test 1959 
  asterisk/trunk/tests/channels/SIP/message_from_call/run-test 1959 
  asterisk/trunk/tests/channels/SIP/message_unauth/run-test 1959 
  asterisk/trunk/tests/channels/SIP/noload_res_srtp/run-test 1959 
  asterisk/trunk/tests/channels/SIP/noload_res_srtp_attempt_srtp/run-test 1959 
  asterisk/trunk/tests/channels/SIP/secure_bridge_media/run-test 1959 
  asterisk/trunk/tests/channels/SIP/options/run-test 1959 
  asterisk/trunk/tests/udptl/run-test 1959 
  asterisk/trunk/tests/udptl_v6/run-test 1959 
  asterisk/trunk/tests/regressions/M18882/run-test 1959 
  asterisk/trunk/tests/pbx/pbx_lua_goto/run-test 1959 
  asterisk/trunk/tests/pbx/pbx_lua_background/run-test 1959 
  asterisk/trunk/tests/pbx/merge_contexts/run-test 1959 
  asterisk/trunk/tests/pbx/call-files/run-test 1959 
  asterisk/trunk/tests/one-step-parking/run-test 1959 
  asterisk/trunk/tests/mixmonitor_audiohook_inherit/run-test 1959 
  asterisk/trunk/tests/mixmonitor/run-test 1959 

Diff: https://reviewboard.asterisk.org/r/1386/diff


Testing
-------

Local development box


Thanks,

Paul

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110826/b036975c/attachment-0001.htm>