[asterisk-dev] [Code Review] Make send_text() prefer real-time text if it is available (patch submitted by Emmanuel BUU on JIRA)

[Gunnar Hellström]

It is very good and important that this functionality gets into proper 
released Asterisk.

The same logic is included in implementations in some other 
implementation environments. So it makes very good sense to have it in 
Asterisk as well.

Thanks,
Gunnar

-----------------

Terry Wilson skrev 2011-08-24 20:25:
> This is an automatically generated e-mail. To reply, visit: 
> https://reviewboard.asterisk.org/r/1356/
>
>
> If no one has a problem with this change, I'm going to go ahead and commit it tomorrow even without a "Ship It!" since it isn't originally my patch and therefor I just as easily could have reviewed it myself. I just wanted to make sure to give people a chance to comment.
>
> - Terry
>
>
> On August 9th, 2011, 11:27 a.m., Terry Wilson wrote:
>
> Review request for Asterisk Developers.
> By Terry Wilson.
>
> /Updated Aug. 9, 2011, 11:27 a.m./
>
>
>   Description
>
> This patch was submitted by Emmanuel BUU on JIRA. I have just updated it for trunk and done some testing.
>
> This patch causes the send_text() function (and therefor the SendText dialplan application and other places in the code) to use the write_text() callback to write text frames to the channel instead of using the send_text callback to do a more out-of-band transmission. If text has not been negotiated, or there is no write_text callback, things behave as they always have.
>
> I am placing this up for review so that there can be some public discussion just to make sure this seems like reasonable behavior to everyone.
>
>
>   Testing
>
> I have tested with SIPcon1 and verified that the T.140 text works. I have also tried with a client that didn't support real-time text and saw that SIP MESSAGE requests were sent as they were before.
>
> *Bugs: * ASTERISK-17937 
> <https://issues.asterisk.org/jira/browse/ASTERISK-17937>
>
>
>   Diffs
>
>     * /trunk/main/channel.c (331042)
>
> View Diff <https://reviewboard.asterisk.org/r/1356/diff/>
>
>
> --
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>     http://lists.digium.com/mailman/listinfo/asterisk-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110824/aacdf582/attachment.htm>