[asterisk-dev] [Code Review] Add the ability to parse RC and BETA in an Asterisk version.

[Shaun Ruffell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1375/#review4089
-----------------------------------------------------------



asterisk/trunk/lib/python/asterisk/version.py
<https://reviewboard.asterisk.org/r/1375/#comment8032>

    I think subtracting the weights like this isn't completely safe:
    
    The following test will fail:
    
        def test_cmp19(self):
            v1 = AsteriskVersion("1.8.6.1")
            v2 = AsteriskVersion("1.8.6.0-rc11")
            self.assertTrue(v1 > v2)
    


- Shaun


On Aug. 18, 2011, 3:42 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1375/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2011, 3:42 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds the ability to parse Asterisk 1.8.6.0-rc1 properly in the testsuite.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/lib/python/asterisk/version.py 1867 
> 
> Diff: https://reviewboard.asterisk.org/r/1375/diff
> 
> 
> Testing
> -------
> 
> unit tests
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110818/3ba15438/attachment-0001.htm>