[asterisk-dev] [Code Review] Allow spaces in standard paths and DESTDIR

Tilghman Lesher reviewboard at asterisk.org
Wed Aug 10 18:40:37 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1326/
-----------------------------------------------------------

(Updated Aug. 10, 2011, 6:40 p.m.)


Review request for Asterisk Developers, Russell Bryant and Kevin Fleming.


Changes
-------

Add an explicit comment about the number of paths tested in configure.ac, and modify 'make samples' target to work correctly.


Summary
-------

Support for spaces in standard paths was recently reverted, because spaces in DESTDIR were not supported.  This patch implements changes allowing spaces within both standard application paths (standard on Mac OS X), as well as within DESTDIR.


Diffs (updated)
-----

  /branches/1.8/Makefile 331537 
  /branches/1.8/Makefile.moddir_rules 331537 
  /branches/1.8/agi/Makefile 331537 
  /branches/1.8/configure UNKNOWN 
  /branches/1.8/configure.ac 331537 
  /branches/1.8/include/asterisk/autoconfig.h.in 331537 
  /branches/1.8/makeopts.in 331537 
  /branches/1.8/sounds/Makefile 331537 
  /branches/1.8/utils/Makefile 331537 

Diff: https://reviewboard.asterisk.org/r/1326/diff


Testing
-------

Verified that the install routines run correctly when there are spaces in both standard application paths, as well as in DESTDIR.


Thanks,

Tilghman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110810/8fd51a41/attachment.htm>


More information about the asterisk-dev mailing list