[asterisk-dev] [Code Review] Allow ENUM query functions to report lookup errors

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1355/#review4003
-----------------------------------------------------------

Ship it!



trunk/main/enum.c
<https://reviewboard.asterisk.org/r/1355/#comment7859>

    I assume that this is where you are differentiating between the different kinds of failures.  Any chance of getting this represented in a string form like it was before instead of with a number?  We generally like stuff like this to be represented in a readable form.



trunk/main/enum.c
<https://reviewboard.asterisk.org/r/1355/#comment7858>

    It looks like these are spaces followed by tabs for some reason.  Fix that.


All in all though, this looks safe enough for trunk.

- jrose


On Aug. 9, 2011, 9:30 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1355/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2011, 9:30 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The ENUM dialplan functions do not report DNS query errors properly. It is useful to differentiate between failed query (e.g. non-existent domain) vs. no data records of the appropriate type. This is required to make overlapped dialing work.
> 
> 
> This addresses bug ASTERISK-13769.
>     https://issues.asterisk.org/jira/browse/ASTERISK-13769
> 
> 
> Diffs
> -----
> 
>   trunk/UPGRADE.txt 330825 
>   trunk/funcs/func_enum.c 330825 
>   trunk/main/enum.c 330825 
> 
> Diff: https://reviewboard.asterisk.org/r/1355/diff
> 
> 
> Testing
> -------
> 
> Tested number lookups with multiple results, 1 result, 0 results, and lookup failures.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110809/d9d47e6d/attachment-0001.htm>