[asterisk-dev] [Code Review] Allow spaces in standard paths and DESTDIR

[Paul Belanger]

On 11-07-21 12:26 PM, Tilghman Lesher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1326/
> -----------------------------------------------------------
>
> (Updated July 21, 2011, 11:26 a.m.)
>
>
> Review request for Asterisk Developers, Russell Bryant and Kevin Fleming.
>
>
> Changes
> -------
>
> Addressed Kevin's suggestions.
>
>
> Summary
> -------
>
> Support for spaces in standard paths was recently reverted, because spaces in DESTDIR were not supported.  This patch implements changes allowing spaces within both standard application paths (standard on Mac OS X), as well as within DESTDIR.
>
I had a chance to test this yesterday, but ran into an issue when 
installing samples (see below):

-----
build_tools/make_sample_voicemail "//Library/Application 
Support/Asterisk" "//var/spool/asterisk"
/bin/sh: line 0: [: /Library/Application: binary operator expected
Installing file phoneprov/000000000000-directory.xml
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
                [-o owner] file1 file2
        install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
                [-o owner] file1 ... fileN directory
        install -d [-v] [-g group] [-m mode] [-o owner] directory ...
/bin/sh: line 0: [: /Library/Application: binary operator expected
Installing file phoneprov/000000000000-phone.cfg
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
                [-o owner] file1 file2
        install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
                [-o owner] file1 ... fileN directory
        install -d [-v] [-g group] [-m mode] [-o owner] directory ...
/bin/sh: line 0: [: /Library/Application: binary operator expected
Installing file phoneprov/000000000000.cfg
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
                [-o owner] file1 file2
        install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
                [-o owner] file1 ... fileN directory
        install -d [-v] [-g group] [-m mode] [-o owner] directory ...
/bin/sh: line 0: [: /Library/Application: binary operator expected
Installing file phoneprov/polycom.xml
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
                [-o owner] file1 file2
        install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
                [-o owner] file1 ... fileN directory
        install -d [-v] [-g group] [-m mode] [-o owner] directory ...
/bin/sh: line 0: [: /Library/Application: binary operator expected
Installing file phoneprov/polycom_line.xml
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
                [-o owner] file1 file2
        install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
                [-o owner] file1 ... fileN directory
        install -d [-v] [-g group] [-m mode] [-o owner] directory ...
/bin/sh: line 0: [: /Library/Application: binary operator expected
Installing file phoneprov/snom-mac.xml
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
                [-o owner] file1 file2
        install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
                [-o owner] file1 ... fileN directory
        install -d [-v] [-g group] [-m mode] [-o owner] directory ...
make: *** [samples] Error 64


-- 
Paul Belanger
Digium, Inc. | Software Developer
twitter: pabelanger | IRC: pabelanger (Freenode)
Check us out at: http://digium.com & http://asterisk.org