[asterisk-dev] [Code Review] Allow empty display name if callerid is set to an empty string. Take 2!

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1341/#review3984
-----------------------------------------------------------


But there are still issues to be considered here.

Currently, since this change doesn't send a display name when there is no caller id, certain tests are bouncing mostly revolving around CDR expectation of caller id.
This failure in particular is in many of the CDR tests:

CDR MATCH FAILED, Expected: callerid:"asterisk" <asterisk> Got: callerid:asterisk

Right now, I'm currently considering whether we should be stripping the display name if we have neither a name or a number.  That would probably fix these problems, but I'm not sure whether the issue would be resolved by that change.  Changing the tests is another option, but I'm still unsure if that's the only impact, and in addition, there would be different expected behavior between Asterisk 10 and before from Asterisk 11 in that case... which is awkward and makes the tests harder to maintain.

A number of tests remain that still need to be ran, so it's going to take a while to know the full impact.

- jrose


On Aug. 3, 2011, 9:57 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1341/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2011, 9:57 a.m.)
> 
> 
> Review request for Asterisk Developers, David Vossel and rmudgett.
> 
> 
> Summary
> -------
> 
> This is basically what I was trying to do with the user submitted patch from yesterday.  After speaking with Richard, it became somewhat obvious that the approach to the patch had too much extra impact on the SIP messages when all that was really needed was specifically targeting the creation of the display name.
> 
> This approach checks strictly for a caller id name and if it isn't there, we skip the creation of the display name.  I think this should be safer in general than the previous approach.
> 
> 
> This addresses bug ASTERISK-16198.
>     https://issues.asterisk.org/jira/browse/ASTERISK-16198
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 330571 
>   /trunk/channels/chan_sip.c 330571 
> 
> Diff: https://reviewboard.asterisk.org/r/1341/diff
> 
> 
> Testing
> -------
> 
> Testing was similar to last time with focus on comparing the SIP messages between this branch and the normal trunk.  In this case, only the display name gets changed.
> 
> A few SIP tests from the test suite were also ran successfully.  I haven't ran the full test suite yet, but am preparing to do so.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110803/14d736d6/attachment-0001.htm>