[asterisk-dev] [Code Review]: Call pickup broken for DAHDI channels when beginning with #

[opticron]

> On Aug. 1, 2011, 4:30 p.m., rmudgett wrote:
> > trunk/channels/sig_analog.c, lines 2297-2301
> > <https://reviewboard.asterisk.org/r/1336/diff/1/?file=17691#file17691line2297>
> >
> >     This test is not going to always work.
> >     ast_pickup_ext() could be an arbitrary length string like: 123456
> >     
> >     The test really needs to check to see if the currently dialed digits are start of an extension or the start of any of the special codes.  (*70, *69, *67, *72, *73, *60,...)

This should be addressed in the new patch.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1336/#review3957
-----------------------------------------------------------


On Aug. 1, 2011, 3:52 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1336/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2011, 3:52 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The call pickup feature did not work on DAHDI devices for anything other than feature codes beginning with * since all feature codes in chan_dahdi were originally hard-coded to begin with *.  This patch is also applied to chan_dahdi.c to fix this bug with GR.303.
> 
> 
> This addresses bug AST-621.
>     https://issues.asterisk.org/jira/browse/AST-621
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_dahdi.c 330488 
>   trunk/channels/sig_analog.c 330488 
> 
> Diff: https://reviewboard.asterisk.org/r/1336/diff
> 
> 
> Testing
> -------
> 
> Verified bug with TDM410P.  Tested patch with various call pickup feature codes beginning with * and #.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110802/b3813420/attachment.htm>