[asterisk-dev] [Code Review] Multiple parking lots parkedcall/transfers/reparking/hangup/recording no handled properly

[Mitch Sharp]

> On 2011-04-26 10:12:36, Paul Belanger wrote:
> > tags/1.6.2.17.2/main/features.c, lines 3983-3988
> > <https://reviewboard.asterisk.org/r/1194/diff/1/?file=16241#file16241line3983>
> >
> >     if statements need braces.
> >     
> >     if (...) {
> >     
> >     } else if (...) {
> >     
> >     }

I have fixed the braces, but the original issue has been closed.  I fixed the braces in the original code as well, but there are still a tone of if, if else, and if else if statements that have improper bracing.


- Mitch


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1194/#review3426
-----------------------------------------------------------


On 2011-04-21 16:02:16, Mitch Sharp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1194/
> -----------------------------------------------------------
> 
> (Updated 2011-04-21 16:02:16)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I fixed the handling of some variables in multiple parking lots in bug 0016641. The current permutation of the code in 1.6.17.2 doesn't work.
> 
> This has been reverted in trunk already, but the bad code is still in the 1.6.2 tree.
> 
> All this patch does is revert back to the original code, which is the same code that has existed in the load_config function... basically copied to the build_parkinglot function.
> 
> 
> This addresses bug 19167.
>     https://issues.asterisk.org/view.php?id=19167
> 
> 
> Diffs
> -----
> 
>   tags/1.6.2.17.2/main/features.c 314157 
> 
> Diff: https://reviewboard.asterisk.org/r/1194/diff
> 
> 
> Testing
> -------
> 
> Every time I build a new 1.6.2 box I use this patch.
> 
> 
> Thanks,
> 
> Mitch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110427/964a4f3f/attachment.htm>