[asterisk-dev] [Code Review] app_directed_pickup Implement the ability to remove a channel group on bridged channel

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1118/
-----------------------------------------------------------

(Updated 2011-04-27 08:39:15.607533)


Review request for Asterisk Developers.


Changes
-------

Moved the "unlock" to the wrong place small fixup.


Summary
-------

as a companion to 0018825 to aid with the move from call-limits to channel group variables. the problem with pickup and queue is that they manage channels outside the dialplan and need "helpers" to deal with channel groups.

in the case of pickup when a call is placed to a extension with say a "<EXTEN>@called" channel group when it is picked up this needs to be cleared to allow further calls when call waiting is disabled.

exten => s,n,GotoIf($[$[${ GROUP_COUNT(${ARG1}@called)} >= 1] | $[${GROUP_COUNT(${ARG1}@caller)} >= 1] | $[${GROUP_COUNT(${ARG1}@pickup)} >= 1] | $[${GROUP_COUNT(${ARG1}@qagent)} >= 1]]?s-BUSY,1)

where
caller is set when a call is placed.
called is set when a call is received
pickup is set when before calling pickup in the dialplan
qagent is set with patch to queue

Hope this is found to be useful and finds a home in trunk. 

not sure what time to put in the "wait for bridge" perhaps there is a better method ?? 


This addresses bug 18830.
    https://issues.asterisk.org/view.php?id=18830


Diffs (updated)
-----

  /trunk/apps/app_directed_pickup.c 315724 
  /trunk/main/channel.c 315724 

Diff: https://reviewboard.asterisk.org/r/1118/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110427/474616a1/attachment.htm>