[asterisk-dev] [Code Review] The 'e' special extension fails to trigger in at least two cases.

[Matthew Nicholson]

> On 2011-04-26 12:15:44, Matthew Nicholson wrote:
> > /branches/1.8/main/pbx.c, line 9338
> > <https://reviewboard.asterisk.org/r/1196/diff/2/?file=16254#file16254line9338>
> >
> >     You could use pbx_builtin_raise_exception here.
> 
> rmudgett wrote:
>     I could, but I wanted to be more explicit and also match the 't' goto above.

Understood. It works just fine both ways.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1196/#review3433
-----------------------------------------------------------


On 2011-04-25 17:05:54, rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1196/
> -----------------------------------------------------------
> 
> (Updated 2011-04-25 17:05:54)
> 
> 
> Review request for Asterisk Developers and Matthew Nicholson.
> 
> 
> Summary
> -------
> 
> The 'e' extension is a fall back for the 'i', 't', or 'T' extensions if any of them do not exist.
> 
> Many of the places the 'e' extension was supposed to be invoked fail because the priority was set wrong.  There were two places where the 'e' extension was not even checked for fall back.
> 
> 
> This addresses bug 19136.
>     https://issues.asterisk.org/view.php?id=19136
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/pbx.c 315348 
> 
> Diff: https://reviewboard.asterisk.org/r/1196/diff
> 
> 
> Testing
> -------
> 
> Code inspection.  The 'e' extension is invoked similarly to the other exception extensions: 'i', 't', and 'T' since it is a fall back for the other extensions.
> 
> Done some actual testing and code worked as intended.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110426/264fc88a/attachment.htm>