[asterisk-dev] [Code Review] Fix reference leaks in addition to those fixed in review 1101

[rgagnon]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1198/#review3428
-----------------------------------------------------------

Ship it!


I would agree with the change had I found it myself :-)

- rgagnon


On 2011-04-26 10:54:16, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1198/
> -----------------------------------------------------------
> 
> (Updated 2011-04-26 10:54:16)
> 
> 
> Review request for Asterisk Developers, David Vossel and rgagnon.
> 
> 
> Summary
> -------
> 
> In reviewing rgagnon's https://reviewboard.asterisk.org/r/1101 I found a couple of additional memory leaks. This change builds upon his changes and is dependent on them.
> 
> 1. peer_is_marked():
>    Change AST_SCHED_DEL to AST_SCHED_DEL_UNREF for peer->pokeexpire and also add an AST_SCHED_DEL_UNREF for peer->expire as we were leaking peers who had registered to us when removing them from sip.conf and doing a sip reload
> 
> 2 find_call():
>   When pedantic mode is enabled and the trylock fail, we do a goto restartsearch and need to unref the pvt that ao2_callback finds.
> 
> 
> Diffs
> -----
> 
>   /team/group/issue_17255-1.6.2/channels/chan_sip.c 315441 
> 
> Diff: https://reviewboard.asterisk.org/r/1198/diff
> 
> 
> Testing
> -------
> 
> #define REF_DEBUG 1 and used utils/refcounter to verify that dialog's refcounts were balanced when pedantic mode was enabled and that peers who registered to us also balanced when being removed from sip.conf.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110426/150063de/attachment.htm>