[asterisk-dev] [Code Review] Add MixMonitor and StopMixMonitor AMI actions

[jrose]

> On 2011-04-20 15:48:11, jrose wrote:
> > http://svn.asterisk.org/svn/asterisk/branches/1.8/apps/app_mixmonitor.c, lines 746-749
> > <https://reviewboard.asterisk.org/r/1193/diff/1/?file=16223#file16223line746>
> >
> >     Highlighting more lines so it's obvious what I'm talking about in the previous comment.
> 
> telecos82 wrote:
>     I've followed the same logic as in manager_mute_mixmonitor which, on error, calls astman_send_error but retruns AMI_SUCCESS. I understood from this that, despite the action itself has failed (e.g. no channel found so no action can be done over such channel), the AMI command has finished well (AMI_SUCCESS or 0). Is this not correct?
> 
> jrose wrote:
>     I'm probably wrong then.  I'm curious though what would be a case of AMI failure.  Off to find out.

Ok, yeah, this is right.  It looks like there isn't even an AMI_FAILURE type thing right now and the only other options right now would just destroy the manager session, which is obviously not wanted.  You've got it right.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1193/#review3413
-----------------------------------------------------------


On 2011-04-21 03:01:47, telecos82 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1193/
> -----------------------------------------------------------
> 
> (Updated 2011-04-21 03:01:47)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add MixMonitor and StopMixMonitor AMI actions to allow starting and stopping MixMonitor from AMI.
> 
> 
> This addresses bug 19155.
>     https://issues.asterisk.org/view.php?id=19155
> 
> 
> Diffs
> -----
> 
>   http://svn.asterisk.org/svn/asterisk/branches/1.8/apps/app_mixmonitor.c 314406 
> 
> Diff: https://reviewboard.asterisk.org/r/1193/diff
> 
> 
> Testing
> -------
> 
> Tested with SIP, IAX and DAHDI channels.
> 
> 
> Thanks,
> 
> telecos82
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110421/98124362/attachment-0001.htm>