[asterisk-dev] [Code Review] Add MixMonitor and StopMixMonitor AMI actions

[jrose]

> On 2011-04-21 06:58:59, Olle E Johansson wrote:
> > I would prefer one action called "MixMonitor" with an operation header that specifies if you want to know the state, or turn it on or off. 
> > 
> > Action: Mixmonitor
> > Operation: Start
> > Channel: SIP/olle-12345
> > 
> > Action: Mixmonitor
> > Operation: Query
> > Channel: SIP/terry-54321
> > 
> > Action: Mixmonitor
> > Operation: Stop
> > Channel: SIP/russell-6666
> > 
> > /O

Just noting that the way it's handled in terms of applications is that you have separate MixMonitor and StopMixMonitor applications.  I'm a little curious why AGI should handle it differently, I'd think that just for consistency sake the way it's handled here is better.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1193/#review3416
-----------------------------------------------------------


On 2011-04-21 03:01:47, telecos82 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1193/
> -----------------------------------------------------------
> 
> (Updated 2011-04-21 03:01:47)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add MixMonitor and StopMixMonitor AMI actions to allow starting and stopping MixMonitor from AMI.
> 
> 
> This addresses bug 19155.
>     https://issues.asterisk.org/view.php?id=19155
> 
> 
> Diffs
> -----
> 
>   http://svn.asterisk.org/svn/asterisk/branches/1.8/apps/app_mixmonitor.c 314406 
> 
> Diff: https://reviewboard.asterisk.org/r/1193/diff
> 
> 
> Testing
> -------
> 
> Tested with SIP, IAX and DAHDI channels.
> 
> 
> Thanks,
> 
> telecos82
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110421/a8578be0/attachment.htm>