[asterisk-dev] [Code Review] Chan_sip: Voice frame dropped for every early media audio call

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1186/
-----------------------------------------------------------

(Updated 2011-04-19 03:21:08.108924)


Review request for Asterisk Developers.


Changes
-------

Updated to include t.38 check inside locking area.


Summary
-------

The code for checking T.38 in sip_write accidentally drops one frame in situations where an audio frame forces early media . If you compare with the video code below this part of the code, the frame is not dropped even though we add an 183 message. It's not a big issue, but nevertheless, frames are frames and should be treated with love and care.

Moved the T.38 check out of the lock - maybe that's wrong?


This addresses bug 19312.
    https://issues.asterisk.org/view.php?id=19312


Diffs (updated)
-----

  /branches/1.4/channels/chan_sip.c 313187 

Diff: https://reviewboard.asterisk.org/r/1186/diff


Testing
-------

Can't test with T.38 - only with audio. It works.


Thanks,

Olle E

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110419/444aa905/attachment.htm>