[asterisk-dev] [Code Review] fix *8 pickup feature code: Create a common ast_do_pickup from app_directed_pickup:pickup_do

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1185/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

debugging mantis 18654, found common code, of which 1 set was wrong, the ast_pickup_call() code in features.c
The actual fault was ast_pickup_call where the target chan was unlocked too early - see bug18654.diff2.txt

Moved app_directed:pickup_do() to features:ast_do_pickup().

Now functions in app_directed_pickup.c: pickup_by_channel(), pickup_by_exten(), pickup_by_mark(),  pickup_by_part()
and in features.c: ast_pickup_call() all now use the new ast_do_pickup().


This addresses bug 18654.
    https://issues.asterisk.org/view.php?id=18654


Diffs
-----

  trunk/apps/app_directed_pickup.c 313856 
  trunk/include/asterisk/features.h 313856 
  trunk/main/features.c 313856 
  trunk/res/res_features.exports.in 313856 

Diff: https://reviewboard.asterisk.org/r/1185/diff


Testing
-------

pickup using *8 feature code, with pickup sounds enabled/disabled
pickup using **{EXTEN} dialplan app Pickup()


Thanks,

Alec

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110417/07032691/attachment.htm>