[asterisk-dev] [Code Review] Move unsupported modules to their own directory

[Tzafrir Cohen]

> On 2011-04-13 16:39:07, David Vossel wrote:
> > This has my full approval.  A few more modules could probably go into this list other than the ones you already have.  It might even be worth discussing a policy to drop some files from the source tree after a few months/years of complete inactivity in the unsupported folder.
> 
> Leif Madsen wrote:
>     Awesome! Ya I have a few more modules in mind, but I wanted to spend most of the time on getting the 'how' right. I'll start coming up with a list of other modules here shortly. Do you think this is appropriate to be discussed on asterisk-dev? Maybe someone will pop up and say, "OH NO! THAT NEEDS TO BE SUPPORTED! I WILL DO IT!" :)
>     
>     My shortlist includes:
>     
>     * app_alarmreceiver
>     * chan_skinny
>     * chan_mobile
>     * app_nbscat
>     * app_amd
>     * app_getcpeid
>     * app_mp3
>     * app_rpt
>     * app_saycounted
>     * app_sendtext
>     * app_sms
>     * chan_phone
>     * chan_mgcp(?)
>     * chan_unistim
>     * chan_usbradio
>     * chan_vpb
> 
> Brad Latus wrote:
>     chan_unistim.. people are actively working on a new big patch for that on issues..
>     
>     The rest do not recall seeing any updates of late

So chan_mobile is:
channnels/
addons/*
unsupports/*

Where should I expect to find it?

If something is deprecated (app_fax.c) it should just be disabled, and eventually removed.

Furthermore, moving does have its own (minor) overhead in messing up the history.


If a module is unsupported, shouldn't it be disabled by default? Certainly channel drivers. Their descriptions should note that they are sub-maintained and/or deprecated.


One minor nit: why does the diff include a change to the configure script?


- Tzafrir


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1181/#review3341
-----------------------------------------------------------


On 2011-04-13 15:42:37, Leif Madsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1181/
> -----------------------------------------------------------
> 
> (Updated 2011-04-13 15:42:37)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> As Asterisk continues to grow, not every modules receives the same amount of love, and some modules receive no love at all. In order to make it more obvious for users which modules are deprecated or unsupported, I've modified menuselect to show modules in their own menu called "Unsupported Modules". This way as things are deprecated, or they no longer have a reasonable level of support, then they can be moved into this directory.
> 
> For modules that get moved here, but someone comes along to support the module, it can of course be moved back to a sub-menu where supported modules live.
> 
> 
> This addresses bug 19117.
>     https://issues.asterisk.org/view.php?id=19117
> 
> 
> Diffs
> -----
> 
>   trunk/Makefile 313699 
>   trunk/addons/Makefile 313699 
>   trunk/addons/app_mysql.c 313699 
>   trunk/addons/app_saycountpl.c 313699 
>   trunk/addons/cdr_mysql.c 313699 
>   trunk/apps/app_dahdibarge.c 313699 
>   trunk/apps/app_db.c 313699 
>   trunk/apps/app_macro.c 313699 
>   trunk/apps/app_readfile.c 313699 
>   trunk/apps/app_setcallerid.c 313699 
>   trunk/channels/chan_h323.c 313699 
>   trunk/configure UNKNOWN 
>   trunk/include/asterisk/autoconfig.h.in 313699 
>   trunk/unsupported/Makefile PRE-CREATION 
>   trunk/unsupported/app_dahdibarge.c PRE-CREATION 
>   trunk/unsupported/app_db.c PRE-CREATION 
>   trunk/unsupported/app_macro.c PRE-CREATION 
>   trunk/unsupported/app_readfile.c PRE-CREATION 
>   trunk/unsupported/app_setcallerid.c PRE-CREATION 
>   trunk/unsupported/chan_h323.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1181/diff
> 
> 
> Testing
> -------
> 
> Ran ./configure && make menuselect
> 
> I then selected a couple of modules from the directory. After running 'make' I verified only the modules I selected built. Everything looks as it should.
> 
> 
> Thanks,
> 
> Leif
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110414/011485e3/attachment.htm>