[asterisk-dev] [Code Review] Move unsupported modules to their own directory

[Leif Madsen]

> On 2011-04-13 16:04:06, rmudgett wrote:
> > Should a distinction be made for files from addons vs files in the normal Asterisk tree?
> > Are you moving the files so their change history comes along with them?

That is something I was debating in my head. *Can* they be moved from Addons? I'm not entirely sure what makes them separate anymore. None of these modules are enabled by default, so if that is the only requirement then it's been satisfied.

I did an 'svn mv' so hopefully that satisfies your second question. If it doesn't, suggestions on how to properly do it is welcome!


- Leif


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1181/#review3340
-----------------------------------------------------------


On 2011-04-13 15:42:37, Leif Madsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1181/
> -----------------------------------------------------------
> 
> (Updated 2011-04-13 15:42:37)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> As Asterisk continues to grow, not every modules receives the same amount of love, and some modules receive no love at all. In order to make it more obvious for users which modules are deprecated or unsupported, I've modified menuselect to show modules in their own menu called "Unsupported Modules". This way as things are deprecated, or they no longer have a reasonable level of support, then they can be moved into this directory.
> 
> For modules that get moved here, but someone comes along to support the module, it can of course be moved back to a sub-menu where supported modules live.
> 
> 
> This addresses bug 19117.
>     https://issues.asterisk.org/view.php?id=19117
> 
> 
> Diffs
> -----
> 
>   trunk/Makefile 313699 
>   trunk/addons/Makefile 313699 
>   trunk/addons/app_mysql.c 313699 
>   trunk/addons/app_saycountpl.c 313699 
>   trunk/addons/cdr_mysql.c 313699 
>   trunk/apps/app_dahdibarge.c 313699 
>   trunk/apps/app_db.c 313699 
>   trunk/apps/app_macro.c 313699 
>   trunk/apps/app_readfile.c 313699 
>   trunk/apps/app_setcallerid.c 313699 
>   trunk/channels/chan_h323.c 313699 
>   trunk/configure UNKNOWN 
>   trunk/include/asterisk/autoconfig.h.in 313699 
>   trunk/unsupported/Makefile PRE-CREATION 
>   trunk/unsupported/app_dahdibarge.c PRE-CREATION 
>   trunk/unsupported/app_db.c PRE-CREATION 
>   trunk/unsupported/app_macro.c PRE-CREATION 
>   trunk/unsupported/app_readfile.c PRE-CREATION 
>   trunk/unsupported/app_setcallerid.c PRE-CREATION 
>   trunk/unsupported/chan_h323.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1181/diff
> 
> 
> Testing
> -------
> 
> Ran ./configure && make menuselect
> 
> I then selected a couple of modules from the directory. After running 'make' I verified only the modules I selected built. Everything looks as it should.
> 
> 
> Thanks,
> 
> Leif
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110413/91a6cf06/attachment.htm>