[asterisk-dev] [Code Review] Chan_dahdi reload memory leak due to variables

[jrose]

> On 2011-04-12 13:11:07, Matthew Nicholson wrote:
> > branches/1.6.2/channels/chan_dahdi.c, line 18125
> > <https://reviewboard.asterisk.org/r/1170/diff/1/?file=16115#file16115line18125>
> >
> >     whitespace

Arg.  Got it.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1170/#review3321
-----------------------------------------------------------


On 2011-04-12 13:02:19, jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1170/
> -----------------------------------------------------------
> 
> (Updated 2011-04-12 13:02:19)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> reload chan_dahdi would cause variables to spill over from the previous config into the current config as well as add any variables in the new config (if left the same, full on duplication)
> This patch purges variables from pvts when they are reconfigured as well as from the configuration pvt once the configuration has been loaded.
> 
> 
> This addresses bug 17450.
>     https://issues.asterisk.org/view.php?id=17450
> 
> 
> Diffs
> -----
> 
>   branches/1.6.2/channels/chan_dahdi.c 313276 
> 
> Diff: https://reviewboard.asterisk.org/r/1170/diff
> 
> 
> Testing
> -------
> 
> !touch /etc/asterisk/chan_dahdi.conf
> reload chan_dahdi
> memory show summary / memory show allocations chan_dahdi.c
> 
> Performed with a variety of chan_dahdi.conf changes (and lack of changes)
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110412/9c0bf676/attachment.htm>