[asterisk-dev] [Code Review] "dahdi show channels group" auto-completion bug

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1168/#review3319
-----------------------------------------------------------



/branches/1.6.2/main/cli.c
<https://reviewboard.asterisk.org/r/1168/#comment6919>

    I plan to shorten this comment already.  This is just for explaining it in this particular code review


- jrose


On 2011-04-11 10:45:33, jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1168/
> -----------------------------------------------------------
> 
> (Updated 2011-04-11 10:45:33)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Tab completion Bug - "dahdi show channels group" continuously adds the word group to the end as you hit tab repeatedly.
> 
> Removed a function more_words from cli.c and removed its use as a conditional for terminating the while loop looking through completion since it seems like it's redundant with the already existing for loop iterating through the existing words.  I'm not sure though.
> 
> 
> This addresses bug 17494.
>     https://issues.asterisk.org/view.php?id=17494
> 
> 
> Diffs
> -----
> 
>   /branches/1.6.2/main/cli.c 313189 
> 
> Diff: https://reviewboard.asterisk.org/r/1168/diff
> 
> 
> Testing
> -------
> 
> Tested patch using dozens of cli commands with a variety of tab completion combinations to make sure it wasn't breaking.  Tested the actual command in question as well of course to make sure it didn't repeat.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110411/66b3ea1f/attachment-0001.htm>