[asterisk-dev] [Code Review] Add 'description' field for SIP peers

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1163/#review3309
-----------------------------------------------------------



trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/1163/#comment6909>

    Add a - to the description field to left justify the description in the column.
    %-32.32s



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1163/#comment6910>

    I think you should leave the %-8i as %-8d.



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1163/#comment6911>

    Extraneous blank line.



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1163/#comment6912>

    Looks like you need a \r\n here.


- rmudgett


On 2011-04-07 14:54:28, Leif Madsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1163/
> -----------------------------------------------------------
> 
> (Updated 2011-04-07 14:54:28)
> 
> 
> Review request for Asterisk Developers and Olle E Johansson.
> 
> 
> Summary
> -------
> 
> Using some of the best practices names for SIP peers provides the quandary of knowing exactly what peer is where, or who it is assigned to.
> 
> If you name all your peers as the MAC address of the device, then it's difficult to determine what device is assigned to whom, or at least knowing where the device physically resides.
> 
> I've added a description field that can help. When you do 'sip show peers' then a new column called Description outputs 32 chars of a description to the Asterisk console.
> 
> 
> This addresses bug 19076.
>     https://issues.asterisk.org/view.php?id=19076
> 
> 
> Diffs
> -----
> 
>   trunk/CHANGES 313094 
>   trunk/channels/chan_dahdi.c 313094 
>   trunk/channels/chan_iax2.c 313094 
>   trunk/channels/chan_sip.c 313094 
>   trunk/channels/sip/include/sip.h 313094 
>   trunk/configs/chan_dahdi.conf.sample 313094 
>   trunk/configs/iax.conf.sample 313094 
>   trunk/configs/sip.conf.sample 313094 
>   trunk/configs/users.conf.sample 313094 
> 
> Diff: https://reviewboard.asterisk.org/r/1163/diff
> 
> 
> Testing
> -------
> 
> Added "description=My Awesome Peer" to [0004f2040001] definition in sip.conf, then did 'sip show peers' and 'sip show peer 0004f2040001'. Output was as expected. Compiled without error or warning.
> 
> 
> Thanks,
> 
> Leif
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110407/e1625987/attachment-0001.htm>