[asterisk-dev] [svn-commits] rmudgett: branch 1.8 r312889 - /branches/1.8/channels/chan_sip.c

[Olle E. Johansson]

7 apr 2011 kl. 10.35 skrev Klaus Darilion:

> 
> 
> Am 07.04.2011 10:20, schrieb Olle E. Johansson:
>> 
>> 7 apr 2011 kl. 10.17 skrev Klaus Darilion:
>> 
>>> 
>>> 
>>> Am 05.04.2011 20:10, schrieb Olle E. Johansson:
>>>> 
>>>> 5 apr 2011 kl. 18.19 skrev SVN commits to the Digium repositories:
>>>> 
>>>>> Add 416 response to OPTIONS packet.
>>>>> 
>>>>> RFC3261 Section 11.2 says the response code to an OPTIONS packet needs to
>>>>> be the same as if it were an INVITE.
>>>> 
>>>> If you start down that path you open up for a massive amount of changes. In order to to this, you have to properly 
>>>> authenticate every OPTIONs so that you can find out the configuration and answer that peer/user correctly.
>>> 
>>> Isn't authentication of OPTIONS already implemented? I remember a code
>>> review for this.
>>> 
>> If so, my apologies. I must have missed that. I hope it's configurable, as it adds a lot of processing to a server, especially if you have realtime.
>> If you only want to use OPTIONs as a PING request the old code worked fine. It did not work for discovery though.
> 
> See
> http://www.mail-archive.com/asterisk-security@lists.digium.com/msg00318.html


Even if my memory is not very impressive, I still have the same opinion :-)

/O