[asterisk-dev] [Code Review] [18801] - features reload does not clear old configuration and always include 700 on parkedcalls : patch

[jrose]

> On 2011-04-06 13:56:15, David Vossel wrote:
> > /trunk/main/features.c, lines 4872-4873
> > <https://reviewboard.asterisk.org/r/1161/diff/1/?file=16059#file16059line4872>
> >
> >     parkinglot_destroy never needs to be called explicitly.  The destruction is performed automatically when the parkinglot's ref count reaches 0.
> >     
> >     Unlinking the parkinglot will release the ref held by the ao2 container.  Once you call  ao2_unref(p, -1) after the unlink the ref count given to the iterator will be decremented.  This should destroy the object.
> >     
> >     
> >     
> >     
> >

Yeah, I thought something like that might be the case.  I'll revise as suggested.


> On 2011-04-06 13:56:15, David Vossel wrote:
> > /trunk/main/features.c, lines 4926-4932
> > <https://reviewboard.asterisk.org/r/1161/diff/1/?file=16059#file16059line4926>
> >
> >     The context doesn't have to be "parkedcalls"

Actually, in this case the context is hard-coded as "parkedcalls".  That's why the bug mentioned including the parkedcalls context even when it wasn't specified in configs.  What happens is that when the load_config function is invoked, the default parkinglot is created and marked to use the "parkedcalls" context and in the build function for the parking lot, the default extension would also be made before any real config stuff is read.  Unfortunately, it seems like the default channel has to be built in this manner for the rest of the function to not explode.

I guess I should probably concentrate on finding a way to make that not be necessary unless a [general] context isn't found.  I'll spend the next little while checking that out.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1161/#review3291
-----------------------------------------------------------


On 2011-04-06 10:50:38, jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1161/
> -----------------------------------------------------------
> 
> (Updated 2011-04-06 10:50:38)
> 
> 
> Review request for Asterisk Developers, David Vossel and rbyrant.
> 
> 
> Summary
> -------
> 
> This fix follows a completely different approach from the other one, so I created a new review request.
> This fix involves wiping all the parking lots in the parkinglots ao2_container while purging their extensions so that they have to be rebuilt when features reload is performed.
> 
> I have a bit more confidence in this one.  It's much more additive and much less destructive than the last one.
> 
> 
> This addresses bug 18801.
>     https://issues.asterisk.org/view.php?id=18801
> 
> 
> Diffs
> -----
> 
>   /trunk/main/features.c 312991 
> 
> Diff: https://reviewboard.asterisk.org/r/1161/diff
> 
> 
> Testing
> -------
> 
> Tested with multiple parking lots, changing multiple parking lots, with and without [general], with general and then without general and then with general again (which showed a need for an additional change), and mixes of all the above.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110406/3b592510/attachment-0001.htm>