[asterisk-dev] [Code Review] Add 'description' field for SIP peers
Leif Madsen
reviewboard at asterisk.org
Wed Apr 6 14:20:43 CDT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1163/
-----------------------------------------------------------
Review request for Asterisk Developers.
Summary
-------
Using some of the best practices names for SIP peers provides the quandary of knowing exactly what peer is where, or who it is assigned to.
If you name all your peers as the MAC address of the device, then it's difficult to determine what device is assigned to whom, or at least knowing where the device physically resides.
I've added a description field that can help. When you do 'sip show peers' then a new column called Description outputs 32 chars of a description to the Asterisk console.
This addresses bug 19076.
https://issues.asterisk.org/view.php?id=19076
Diffs
-----
trunk/channels/chan_sip.c 312991
trunk/channels/sip/include/sip.h 312991
trunk/configs/sip.conf.sample 312991
Diff: https://reviewboard.asterisk.org/r/1163/diff
Testing
-------
Added "description=My Awesome Peer" to [0004f2040001] definition in sip.conf, then did 'sip show peers' and 'sip show peer 0004f2040001'. Output was as expected. Compiled without error or warning.
Thanks,
Leif
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110406/63f9c70b/attachment.htm>
More information about the asterisk-dev
mailing list