[asterisk-dev] [Code Review] Add CLI-command "cdr pgsql status" based on "cdr mysql status"

[Olle E. Johansson]

Since this patch is almost verbatim based on the mysql cdr driver, we should propably update both at the same time.

Thanks for the review - I'll update.

/O
> 
> /trunk/cdr/cdr_pgsql.c
> <https://reviewboard.asterisk.org/r/923/#comment5986>
> 
>    Initialization to 0 is unnecessary, and it's recommended that you leave it off.

> 
> 
> 
> /trunk/cdr/cdr_pgsql.c
> <https://reviewboard.asterisk.org/r/923/#comment5987>
> 
>    There's got to be a way to convert seconds to a friendly time string without open coding it like this.  Perhaps strftime()?
> 
> 
> 
> /trunk/cdr/cdr_pgsql.c
> <https://reviewboard.asterisk.org/r/923/#comment5988>
> 
>    You can use ARRAY_LEN(cdr_pgsql_status_cli) instead of the division you have here.
> 
> 
> - Russell
> 
> 
> On 2010-09-17 06:25:54, Olle E Johansson wrote:
>> 
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviewboard.asterisk.org/r/923/
>> -----------------------------------------------------------
>> 
>> (Updated 2010-09-17 06:25:54)
>> 
>> 
>> Review request for Asterisk Developers.
>> 
>> 
>> Summary
>> -------
>> 
>> Adds a CLI command to check the status of the cdr_pgsql.so driver
>> 
>> 
>> This addresses bug 18009.
>>    https://issues.asterisk.org/view.php?id=18009
>> 
>> 
>> Diffs
>> -----
>> 
>>  /trunk/cdr/cdr_pgsql.c 287085 
>> 
>> Diff: https://reviewboard.asterisk.org/r/923/diff
>> 
>> 
>> Testing
>> -------
>> 
>> The 1.4 version has been in production for more than a month.
>> 
>> 
>> Thanks,
>> 
>> Olle E
>> 
>> 
> 
> 
> -- 
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
> 
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>   http://lists.digium.com/mailman/listinfo/asterisk-dev

---
* Olle E Johansson - oej at edvina.net
* Cell phone +46 70 593 68 51, Office +46 8 96 40 20, Sweden