[asterisk-dev] [Code Review] Newchannel AMI event is missing during masquerading process.

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/937/#review2787
-----------------------------------------------------------

Ship it!


Great work! You might want to add a comment to where the second '/' parsing is taking place to indicate why it is necessary before committing.

- David


On 2010-09-24 15:59:33, Brett Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/937/
> -----------------------------------------------------------
> 
> (Updated 2010-09-24 15:59:33)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Newchannel AMI event is missing during masquerading process.
> 
> 
> This addresses bug 17987.
>     https://issues.asterisk.org/view.php?id=17987
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/main/channel.c 288493 
>   /branches/1.6.2/main/channel.c 288498 
>   /branches/1.8/main/channel.c 288499 
> 
> Diff: https://reviewboard.asterisk.org/r/937/diff
> 
> 
> Testing
> -------
> 
> Tested submitters patch, but noticed possible errors with Local calling extensions that have a slash or an agent with a slash in his name.
> 
> Wrote patch submitted here, and tested before and after the patch in 1.4, 1.6.2, 1.8, and trunk branches.
> 
> 
> Thanks,
> 
> Brett
> 
>