[asterisk-dev] [Code Review] handle_request_subscribe is too slow cause of iterating through all sip dialogs

[sst at sil.at]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/901/
-----------------------------------------------------------

(Updated 2010-09-23 13:35:17.847643)


Review request for Asterisk Developers.


Changes
-------

this is diff for trunk not 1.6.2.
after thinking about david vossels comment i have seen the ast_extension_state_del function will be called from the dialog_unlink_all function. so everything which has to be done here is the needdestroy call. this should keep refs in order.

added this check to the incoming handle switch too.


Summary
-------

in chan_sip.c the handle_request_subscribe function is very slow cause of iterating through all sip dialogs on every subscribe, to find old subscribes from this peer to exten at context. This patch will disable this iteration cause its not necessary.


Diffs (updated)
-----

  trunk/channels/chan_sip.c 288264 

Diff: https://reviewboard.asterisk.org/r/901/diff


Testing
-------


Thanks,

schmidts