[asterisk-dev] [Code Review] SIP: for an INVITE transaction, treat all 2XX responses the same as a 200

[David Vossel]

> On 2010-09-23 05:28:48, schmidts wrote:
> > /trunk/channels/chan_sip.c, line 19897
> > <https://reviewboard.asterisk.org/r/935/diff/1/?file=12586#file12586line19897>
> >
> >     i am not sure but AFAIK there are only two 2xx responses. 200 Ok and 202 Accept.
> >     A 202 in a Refer dialog is handled on Row 19727.
> >     
> >     again AFAIK there could only be a 202 for notifys. So maybe we here it should be handle_response_notify and not invite?
> >

A 202 for an INVITE does not really make sense to me. Since it is not recognized for an INVITE, RFC 3261 says we should process it like a 200 in section 8.1.3.2


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/935/#review2773
-----------------------------------------------------------


On 2010-09-22 17:03:18, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/935/
> -----------------------------------------------------------
> 
> (Updated 2010-09-22 17:03:18)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently if Asterisk receives any 2XX response to an outgoing INVITE other than a 200 it is ignored.  I have changed this behavior to treat all 2XX responses the same as a 200.  RFC3261 section 13.2.2.4 which outlines how a 2XX response should be handled in response to an INVITE request seems to treat all 2XX responses the same.  I don't see any reason why our implementation should be specific to only 200 Ok responses. 
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 288419 
> 
> Diff: https://reviewboard.asterisk.org/r/935/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>