[asterisk-dev] [Code Review] Don't ast_strdupa() from within the arguments to a function

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/927/#review2763
-----------------------------------------------------------

Ship it!


Looks good, here.

- Tilghman


On 2010-09-17 16:07:11, Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/927/
> -----------------------------------------------------------
> 
> (Updated 2010-09-17 16:07:11)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Issue 17902 reported corruption in dnsmgr, as some log entries were reporting IP addresses with the wrong host.  I believe this is due to ast_strdupa() being used from within the arguments to a function.  I went through and found all of the places this had been done in the recent merge of a large patch and changed them.  I know we've had bugs before due to this same thing, but I can't find any references to them on a quick search.
> 
> 
> This addresses bug 17902.
>     https://issues.asterisk.org/view.php?id=17902
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 287385 
>   /branches/1.8/main/acl.c 287385 
>   /branches/1.8/main/dnsmgr.c 287385 
>   /branches/1.8/res/res_rtp_asterisk.c 287385 
> 
> Diff: https://reviewboard.asterisk.org/r/927/diff
> 
> 
> Testing
> -------
> 
> I put this up for testing by the reporter but haven't heard back.  I feel pretty confident that it's a good change to make (even if it didn't completely resolve the reporter's issue, but I think it will).
> 
> 
> Thanks,
> 
> Russell
> 
>