[asterisk-dev] gsmtolin translator seems miss frameout function.

[Kevin P. Fleming]

On 09/16/2010 01:45 AM, John Wu wrote:
> gsmtolin define as:
> 
> static struct ast_translator gsmtolin = {
>     .name = "gsmtolin",
>     .srcfmt = AST_FORMAT_GSM,
>     .dstfmt = AST_FORMAT_SLINEAR,
>     .newpvt = gsm_new,
>     .framein = gsmtolin_framein,
>     .destroy = gsm_destroy_stuff,
>     .sample = gsm_sample,
>     .buffer_samples = BUFFER_SAMPLES,
>     .buf_size = BUFFER_SAMPLES * 2,
>     .desc_size = sizeof (struct gsm_translator_pvt ),
> };
> 
> I can't find the function pointer frameout be set. Will this actually
> work? I doubt it.

Since it does work, clearly it works... otherwise we'd get masses of bug
reports about GSM translation not working :-)

If you read the documentation in translate.h, you'll see that there is a
*default* frameout function used if a translator does not define its own.

-- 
Kevin P. Fleming
Digium, Inc. | Director of Software Technologies
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
skype: kpfleming | jabber: kfleming at digium.com
Check us out at www.digium.com & www.asterisk.org